Merge branch 'master' into internal

* master: [FIX JENKINS-19580] Fix project list auto-completion broken by multiple-Gerrit feature Fix project list auto-completion broken by pull-req #64. Handle concurrent Gerrit queries and manual triggers with different servers and users. More null checks Restore English as default language in server config page. Add and clean-up null-checks. Fixed license formatting Literally changed README to markdown Implement new connection listener solution to gerrit-trigger Fix tests for gerrit-events Fix Javadoc comment Remove listener collection and interfaces from GerritHandler class Add listener collection and interfaces to GerritConnection class Remove interfaces for ConnectionListener from Handler Add marker to added string resources Move properties for GerritManagement to GerritServer Remove index.properties in GerritManagement Fix typo BuildChooser to retrieve the revision to be built from GerritEvent Fix unreviewed patches NPE by adding serverName info to event provider. Add check for retrigger after rename. Fix Manual Query. GerritTrigger.equals/hashCode -- don't use AbstractProject Fix GerritProjectListTest to have no dependency on the tests execution order Increase time-out limits to make tests pass more easily. Add auto-completion to "Copy Server From". Fix creation of new server from existing config. Add null check for getServer in GerritManagement. Prohibit removal of the last server. Fix empty verdict category list in "comment added" events. Enable server renaming. Fix copyright Fix test error in ManualTriggerActionPermissionTest. Refactor the GerritManagement page and add null checks. Update help Coordinate tests Add topic pattern to dynamic trigger Provide new build parameter: GERRIT_TOPIC Fix checkstyle error Add topic field into jelly Implement changed parameters in GerritProject Add interesting pattern for topic Add topic key in Change Move server list initialization to PluginImpl.load() Fix tests. [JENKINS-17850] Add multiple Gerrit server support Move message getters to ParameterExpander. Add License and copyright headers to new files. Use all allowing authscope Add button for testing http rest connection Store password as a secret. Use REST Api for submitting review Change-Id: I7c8766706d02a6a5f35ef5fdabe87933406ce613
jenkinsci · Oct 11, 2013 · 6138843 · 6138843
2 parents 89dc9c2 + 862588a
commit 6138843
Show file tree

Hide file tree

Showing 90 changed files with 4,614 additions and 1,545 deletions.
diff --git a/.cloudbees.md b/.cloudbees.md
diff --git a/.jenkins/artifacts.lst b/.jenkins/artifacts.lst
@@ -0,0 +1,2 @@
+**/target/*.hpi
+**/target/*.jar
diff --git a/.jenkins/junit.lst b/.jenkins/junit.lst
@@ -0,0 +1 @@
+**/target/surefire-reports/*.xml
diff --git a/README.md b/README.md
@@ -0,0 +1,85 @@
+# Gerrit Trigger Plugin
+
+This plugin triggers builds on events from the Gerrit code review system by
+retrieving events from the Gerrit command "stream-events", so the trigger is
+pushed from Gerrit instead of pulled as scm-triggers usually are.
+
+Various types of events can trigger a build, multiple builds can be triggered
+by one event, and one consolidated report is sent back to Gerrit.
+
+Multiple Gerrit server connections can be established per Jenkins instance.
+Each job can be configured with one Gerrit server.
+
+
+## Maintainers
+
+* Robert Sandell
+  - robert.sandell@sonymobile.com
+  - sandell.robert@gmail.com
+
+* Tomas Westling
+  - tomas.westling@sonymobile.com
+
+
+# Environments
+* `linux`
+    * `java-1.6`
+        * `maven-3.0.4`
+
+You should have no problem running the plugin on a Windows server.
+The maintainers' development, tests and production environments are
+Ubuntu 12.04 so we have no means of detecting or fixing any Windows issues,
+but there are some kind contributors who provides win fixes every now and then.
+
+To build it however some of the tests needs ssh-keygen to be available,
+so some kind of GNU-like system is needed.
+
+
+# Build
+
+This is a multi module maven project, with all the maven derpiness that follows
+with it. One of the modules _(build-config)_ contains CheckStyle configurations
+for the other modules to use and needs to be installed into your local repo so 
+the maven checkstyle plugin can find it. 
+But simplest is to run install on the entire project.
+
+    mvn clean install
+
+Run findbugs for future reference
+or to make sure you haven't introduced any new warnings
+
+    mvn findbugs:findbugs
+
+# Test local instance
+
+To test in a local Jenkins instance
+
+    cd gerrithudsontrigger
+    mvn hpi:run
+
+
+# License
+
+    The MIT License
+
+    Copyright 2010 Sony Ericsson Mobile Communications. All rights reserved.
+    Copyright 2012 Sony Mobile Communications AB. All rights reserved.
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in
+    all copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+    THE SOFTWARE.
+
diff --git a/README.txt b/README.txt