Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[JENKINS-40059] CommentAdded trigger firing on every comment
The CommentAdded trigger was firing on any comment after the necessary value of an approval had been met. This was happening due to that in previous versions of gerrit before 2.13.0 approval information only appeared once something had changed. This changed to use the oldValue that would optionally be included on state change. The logic added to the gerrit-trigger-plugin was based on an earlier patchset that had an ever present variable for state change. This led to a fall through to the old style of checking for whether to trigger based on a comment.
- Loading branch information
Tyrone Abdy
committed
Nov 29, 2016
1 parent
ebc8cf6
commit 0a8e1c2
Showing
2 changed files
with
19 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters