JENKINS-50603: Verify that the job was a favorite before adding it again

jenkinsci · Apr 18, 2018 · 030b2af · 030b2af
1 parent 983893f
commit 030b2af
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java b/src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java
@@ -21,7 +21,7 @@ public void onRenamed(Item item, String oldName, String newName) {
       for (User user : User.getAll()) {
         FavoriteUserProperty fup = user.getProperty(FavoriteUserProperty.class);
         try {
-          if (fup != null) {
+          if (fup != null && fup.isJobFavorite(oldName)) {
             fup.deleteFavourite(oldName);
             fup.addFavorite(newName);
           }