[JENKINS-19377] Workaround can be removed when using newer parent POM.

jenkinsci · Dec 4, 2013 · 0a19f88 · 0a19f88
1 parent e6ae5af
commit 0a19f88
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/pom.xml b/pom.xml
@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>1.468</version>
+    <version>1.532.1</version>
   </parent>
 
   <artifactId>external-monitor-job</artifactId>
@@ -14,16 +14,6 @@
 
   <url>https://wiki.jenkins-ci.org/display/JENKINS/Monitoring+external+jobs</url>
 
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>animal-sniffer-maven-plugin</artifactId>
-        <!-- details defined in the parent POM -->
-      </plugin>
-    </plugins>
-  </build>
-
   <scm>
     <connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
     <developerConnection>scm:git:git@github.com:jenkinsci/${project.artifactId}-plugin.git</developerConnection>

diff --git a/src/main/java/hudson/model/ExternalJob.java b/src/main/java/hudson/model/ExternalJob.java
@@ -34,8 +34,6 @@
 import javax.servlet.http.HttpServletResponse;
 import java.io.File;
 import java.io.IOException;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 
 /**
  * Job that runs outside Hudson whose result is submitted to Hudson
@@ -46,8 +44,6 @@
  */
 public class ExternalJob extends ViewJob<ExternalJob,ExternalRun> implements TopLevelItem {
 
-    private static final Logger LOGGER = Logger.getLogger(ExternalJob.class.getName());
-
     public ExternalJob(String name) {
         this(Jenkins.getInstance(),name);
     }
@@ -65,13 +61,6 @@ public ExternalRun create(File dir) throws IOException {
         });
     }
 
-    // TODO JENKINS-19377 overriding until 1.531 when this is fixed in core
-    @Override public void removeRun(ExternalRun run) {
-        if (runs != null && !runs.remove(run)) {
-            LOGGER.log(Level.WARNING, "{0} did not contain {1} to begin with", new Object[] {this, run});
-        }
-    }
-
     // keep track of the previous time we started a build
     private transient long lastBuildStartTime;