Merge pull request #9 from oleg-nenashev/bug/JENKINS-44965

[JENKINS-44965] - Restrict the direct access to EnvInjectAction#envMap
jenkinsci · Jun 22, 2017 · 9e9ded8 · 9e9ded8
2 parents 0aa6ccd + db57fc3
commit 9e9ded8
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java b/src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
@@ -16,6 +16,8 @@
 import javax.annotation.CheckForNull;
 import javax.annotation.Nonnull;
 import jenkins.model.RunAction2;
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
 
 /**
  * @author Gregory Boissinot
@@ -24,6 +26,12 @@ public class EnvInjectAction implements RunAction2, StaplerProxy {
 
     public static final String URL_NAME = "injectedEnvVars";
 
+    /**
+     * Local cache of environment variables.
+     * This cache may be null if the loading has never been performed.
+     * Use {@link #getEnvMap()} in external API
+     */
+    @Restricted(NoExternalUse.class)
     protected transient @CheckForNull Map<String, String> envMap;
 
     private transient @Nonnull Run<?, ?> build;