[FIXED JENKINS-10236]Emma plugin causes maven release job to fail

jenkinsci · May 6, 2012 · bcad739 · bcad739 · hostirosti · Jul 3, 2012
1 parent d3a87fb
commit bcad739
Showing 1 changed file with 38 additions and 3 deletions.
diff --git a/src/main/java/hudson/plugins/emma/EmmaPublisher.java b/src/main/java/hudson/plugins/emma/EmmaPublisher.java
@@ -4,6 +4,9 @@
 import hudson.Extension;
 import hudson.FilePath;
 import hudson.Launcher;
+import hudson.maven.ExecutedMojo;
+import hudson.maven.MavenBuild;
+import hudson.maven.MavenModuleSetBuild;
 import hudson.model.AbstractBuild;
 import hudson.model.AbstractProject;
 import hudson.model.Action;
@@ -94,13 +97,27 @@ protected static void saveCoverageReports(FilePath folder, FilePath[] files) thr
 
     @Override
     public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListener listener) throws InterruptedException, IOException {
+        final PrintStream logger = listener.getLogger();
+
+        // Make sure Emma actually ran
+        if (build instanceof MavenBuild) {
+            MavenBuild mavenBuild = (MavenBuild) build;
+            if (!didEmmaRun(mavenBuild)) {
+                listener.getLogger().println("Skipping Emma coverage report as mojo did not run.");
+                return true;
+            }
+        } else if (build instanceof MavenModuleSetBuild) {
+            MavenModuleSetBuild moduleSetBuild = (MavenModuleSetBuild) build;
+            if (!didEmmaRun(moduleSetBuild.getModuleLastBuilds().values())) {
+                listener.getLogger().println("Skipping Emma coverage report as mojo did not run.");
+                return true;
+            }
+        }
+
         EnvVars env = build.getEnvironment(listener);
         env.overrideAll(build.getBuildVariables());
-
         includes = env.expand(includes);
 
-        final PrintStream logger = listener.getLogger();
-
         FilePath[] reports;
         if (includes == null || includes.trim().length() == 0) {
             logger.println("Emma: looking for coverage reports in the entire workspace: " + build.getWorkspace().getRemote());
@@ -170,6 +187,24 @@ public BuildStepDescriptor<Publisher> getDescriptor() {
         return DESCRIPTOR;
     }
 
+    private boolean didEmmaRun(Iterable<MavenBuild> mavenBuilds) {
+        for (MavenBuild build : mavenBuilds) {
+            if (didEmmaRun(build)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    private boolean didEmmaRun(MavenBuild mavenBuild) {
+        for (ExecutedMojo mojo : mavenBuild.getExecutedMojos()) {
+            if ("org.codehaus.mojo".equals(mojo.groupId) && "emma-maven-plugin".equals(mojo.artifactId)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     @Extension
     public static final BuildStepDescriptor<Publisher> DESCRIPTOR = new DescriptorImpl();