Fix JENKINS-23866

Added call to descriptor.save()
jenkinsci · Nov 16, 2014 · f913d92 · f913d92
1 parent b32a26b
commit f913d92
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -27,8 +27,8 @@
   </repositories>
 
   <scm>
-    <connection>scm:git:https://github.com/jenkinsci/email-ext-template-plugin.git</connection>
-    <developerConnection>scm:git:git@github.com:jenkinsci/email-ext-template-plugin.git</developerConnection>
+    <connection>scm:git:https://github.com/jenkinsci/emailext-template-plugin.git</connection>
+    <developerConnection>scm:git:git@github.com:jenkinsci/emailext-template-plugin.git</developerConnection>
   </scm>
 
   <pluginRepositories>

diff --git a/src/main/java/org/jenkinsci/plugins/emailext_template/ExtEmailTemplateManagement.java b/src/main/java/org/jenkinsci/plugins/emailext_template/ExtEmailTemplateManagement.java
@@ -112,6 +112,7 @@ public HttpResponse doSaveTemplate(StaplerRequest req) {
             if(template != null) {
                 req.bindJSON(template, json);
                 template.setPublisher(req.bindJSON(ExtendedEmailPublisher.class, json));
+                descriptor.save();
             } else {
                 template = req.bindJSON(ExtendedEmailPublisherTemplate.class, json);
                 template.setPublisher(req.bindJSON(ExtendedEmailPublisher.class, json));
@@ -120,6 +121,7 @@ public HttpResponse doSaveTemplate(StaplerRequest req) {
         } catch (ServletException e) {
             e.printStackTrace();
         }
+
         return new HttpRedirect("index");
     }
 

diff --git a/...rces/org/jenkinsci/plugins/emailext_template/ExtendedEmailTemplatePublisher/config.groovy b/...rces/org/jenkinsci/plugins/emailext_template/ExtendedEmailTemplatePublisher/config.groovy
@@ -8,7 +8,6 @@ f = namespace("/lib/form")
 d = namespace("jelly:define")
 
 
-//def templates = hudson.plugins.emailext.plugins.EmailTrigger.all()
 def configured = instance != null
 
 f.entry(title: _("Templates"), description: _("The templates to use for sending emails")) {

diff --git a/src/test/java/org/jeninsci/plugins/emailext_plugin/ExtendedEmailTemplatePublisherTest.java b/src/test/java/org/jeninsci/plugins/emailext_plugin/ExtendedEmailTemplatePublisherTest.java
@@ -56,5 +56,4 @@ public void testRemovedTemplate() throws Exception {
         assertTrue("Template was removed, so we should get the message",
                 b.getLog(100).contains(Messages.ExtendedEmailTemplatePublisher_TemplateRemoved(template.getId())));
     }
-
 }