Fix JENKINS-22041

Added check to see if any tests failed this time that didn't fail last time
jenkinsci · Apr 14, 2014 · de6ee27 · de6ee27
1 parent 7980566
commit de6ee27
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java b/src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java
@@ -39,17 +39,23 @@ public boolean trigger(AbstractBuild<?, ?> build, TaskListener listener) {
         if (build.getTestResultAction() == null)
             return false;
 
+        // if previous run didn't have test results and this one does (with failures)
         if (previousBuild.getTestResultAction() == null)
             return build.getTestResultAction().getFailCount() > 0;
 
+        // if more tests failed during this run
+        if(build.getTestResultAction().getFailCount() >
+                previousBuild.getTestResultAction().getFailCount())
+            return true;
+
+        // if any test failed this time, but not last time
         for (Object result : build.getTestResultAction().getFailedTests()){
             CaseResult res = (CaseResult)result;
             if (res.getAge() == 1)
                 return true;
         }
 
-        return build.getTestResultAction().getFailCount() > 
-                previousBuild.getTestResultAction().getFailCount();
+        return false;
     }
 
     @Extension