Fix JENKINS-14500

- Added a check to see if there are ANY failures, if not then don't send an improvement email.
jenkinsci · Jul 20, 2012 · a82a1c9 · a82a1c9
1 parent 4e7e05a
commit a82a1c9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java b/src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java
@@ -17,12 +17,14 @@ public boolean trigger(AbstractBuild<?, ?> build) {
         if (build.getPreviousBuild().getTestResultAction() == null)
             return false;
 
+        int numCurrFailures = getNumFailures(build);
+
         // The first part of the condition avoids accidental triggering for
         // builds that aggregate downstream test results before those test
         // results are available...
         return build.getTestResultAction().getTotalCount() > 0 &&
-            getNumFailures(build) < 
-                getNumFailures(build.getPreviousBuild());
+            numCurrFailures < getNumFailures(build.getPreviousBuild()) &&
+            numCurrFailures > 0;            
     }
 
     @Override