Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix JENKINS-20198
Removed override of newInstance for EmailTriggerDescriptor. It's not needed because the email triggers should have DataBoundConstructor annotations. The new BindingInterceptor in hudson.model.Descriptor caused an issue with the newInstance method.
  • Loading branch information
slide committed Oct 25, 2013
1 parent 05c5dd6 commit 15832cb
Showing 1 changed file with 0 additions and 16 deletions.
Expand Up @@ -44,20 +44,4 @@ public boolean getDefaultSendToRequester() {
public boolean getDefaultSendToCulprits() {
return false;
}

/**
* Default implementation just creates a new instance of the
* trigger class and returns that.
*/
@Override
public EmailTrigger newInstance(StaplerRequest req, JSONObject formData) {
EmailTrigger res = null;
try {
res = clazz.newInstance();
res.configure(req, formData);
} catch(Exception e) {
// should do something here?
}
return res;
}
}

0 comments on commit 15832cb

Please sign in to comment.