Skip to content

Commit

Permalink
JENKINS-33945 Allow offline nodes to be provisions (back out change)
Browse files Browse the repository at this point in the history
  • Loading branch information
Francis Upton IV committed Mar 31, 2016
1 parent 1227f79 commit 7a3973e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/main/java/hudson/plugins/ec2/SlaveTemplate.java
Expand Up @@ -405,7 +405,9 @@ private boolean checkInstance(PrintStream logger, Instance existingInstance, EC2
logProvision(logger, " false - Node is not partially idle");
return false;
}
else if (node.toComputer().isOffline()) {
// REMOVEME - this was added to force provision to work, but might not allow
// stopped instances to be found - need to investigate further
else if (false && node.toComputer().isOffline()) {
logProvision(logger, " false - Node is offline");
return false;
}
Expand Down

1 comment on commit 7a3973e

@nate-tri
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents on-demand provisioning from working if any otherwise matching node is in the offline state.

It's not clear to me what "force provision to work" means here. Is there an issue number that I can reference?

Please sign in to comment.