[JENKINS-34150] Fixes my observed issue.

I have a reproducable tests case in a propratary implementation using this code that is 100% reproducable. The simple "@echo off" fixes the failing test for me. It seems that in the case that the parent process has been killed (e.g. the slave dies) then all though the script terminates successfully and the wrapper terminates successfully (checked with process monitor) there is no attempt to create the result file. where the parent process has not been killed I never see this issue. All I needed to do to fix the issue I was observing is add @echo off as the first line of the wrapper script. Basically I believe it is trying to echo the commands to be run before running the commands and as there is no longer anything consuming the wrappers input/output when echoing the command it is doomed to fail (but strangely not with an exit code that implies something died!??!
jenkinsci · May 19, 2016 · d156ebf · d156ebf
1 parent 0f09bb5
commit d156ebf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java b/src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
@@ -54,7 +54,7 @@ public String getScript() {
         }
         BatchController c = new BatchController(ws);
 
-        c.getBatchFile1(ws).write(String.format("cmd /c \"\"%s\"\" > \"%s\" 2>&1\r\necho %%ERRORLEVEL%% > \"%s\"\r\n",
+        c.getBatchFile1(ws).write(String.format("@echo off \r\ncmd /c \"\"%s\"\" > \"%s\" 2>&1\r\necho %%ERRORLEVEL%% > \"%s\"\r\n",
                 c.getBatchFile2(ws).getRemote().replace("%", "%%"),
                 c.getLogFile(ws).getRemote().replace("%", "%%"),
                 c.getResultFile(ws).getRemote().replace("%", "%%")