Fix JENKINS-15171

jenkinsci · Sep 16, 2012 · 90e72c3 · 90e72c3
1 parent c1f712c
commit 90e72c3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/dryrun/DryRunProjectAction.java b/src/main/java/org/jenkinsci/plugins/dryrun/DryRunProjectAction.java
@@ -2,6 +2,8 @@
 
 import hudson.model.AbstractProject;
 import hudson.model.Action;
+import hudson.model.Item;
+import org.acegisecurity.AccessDeniedException;
 import org.kohsuke.stapler.StaplerProxy;
 
 /**
@@ -24,7 +26,12 @@ public String getDisplayName() {
     }
 
     public String getUrlName() {
-        return "dryRun";
+        try {
+            target.checkPermission(Item.BUILD);
+            return "dryRun";
+        } catch (AccessDeniedException ae) {
+            return null;
+        }
     }
 
     public Object getTarget() {

diff --git a/src/main/java/org/jenkinsci/plugins/dryrun/DryRunUserAction.java b/src/main/java/org/jenkinsci/plugins/dryrun/DryRunUserAction.java
@@ -1,6 +1,7 @@
 package org.jenkinsci.plugins.dryrun;
 
 import hudson.model.AbstractProject;
+import hudson.model.Item;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
 
@@ -21,6 +22,7 @@ public DryRunUserAction(AbstractProject project) {
 
     @SuppressWarnings("unused")
     public void doDynamic(String token, StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException {
+        project.checkPermission(Item.BUILD);
         project.scheduleBuild(0, new DryRunCause(), new DryRunActivateListenerAction(), new DryRunBuildBadgeAction());
         rsp.forwardToPreviousPage(req);
     }