[JENKINS-19456] Improved sending response codes.

jenkinsci · Sep 9, 2013 · db52e3a · db52e3a
1 parent 531785f
commit db52e3a
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/main/java/hudson/plugins/doclinks/artifacts/ArtifactsDocLinksDocument.java b/src/main/java/hudson/plugins/doclinks/artifacts/ArtifactsDocLinksDocument.java
@@ -33,6 +33,7 @@
 import java.util.zip.ZipFile;
 
 import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletResponse;
 
 import org.codehaus.plexus.util.StringUtils;
 import org.kohsuke.stapler.StaplerRequest;
@@ -157,25 +158,25 @@ public void doDynamic(StaplerRequest req, StaplerResponse resp) throws IOExcepti
         AbstractBuild<?,?> build = getBuild(req);
         if (build == null) {
             LOGGER.warning(String.format("No build found for url %s", req.getRequestURI()));
-            resp.sendError(404);
+            resp.sendError(HttpServletResponse.SC_NOT_FOUND);
             return;
         }
 
         File artifact = new File(build.getArtifactsDir(), getArtifactName());
         if (!artifact.exists()) {
             LOGGER.warning(String.format("Artifact does not exists: %s for %s", getArtifactName(), build.getFullDisplayName()));
-            resp.sendError(404);
+            resp.sendError(HttpServletResponse.SC_NOT_FOUND);
             return;
         }
         if (!artifact.isFile()) {
             LOGGER.warning(String.format("Artifact is not a file: %s for %s", getArtifactName(), build.getFullDisplayName()));
-            resp.sendError(403);
+            resp.sendError(HttpServletResponse.SC_FORBIDDEN);
             return;
         }
 
         if (req.getDateHeader("If-Modified-Since") >= 0) {
             if (req.getDateHeader("If-Modified-Since") >= artifact.lastModified()) {
-                resp.sendError(304);
+                resp.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
                 return;
             }
         }
@@ -193,7 +194,7 @@ public void doDynamic(StaplerRequest req, StaplerResponse resp) throws IOExcepti
                 zip = new ZipFile(artifact);
             } catch (ZipException e) {
                 LOGGER.warning(String.format("Artifact is not a zip file: %s for %s", getArtifactName(), build.getFullDisplayName()));
-                resp.sendError(403);
+                resp.sendError(HttpServletResponse.SC_FORBIDDEN);
                 return;
             }
 
@@ -206,7 +207,7 @@ public void doDynamic(StaplerRequest req, StaplerResponse resp) throws IOExcepti
 
             ZipEntry entry = getFileEntry(zip, path);
             if (entry == null) {
-                resp.sendError(404);
+                resp.sendError(HttpServletResponse.SC_NOT_FOUND);
                 return;
             }