[FIXED JENKINS-12987]

To remove items from the list while iterating, we need to use Iterator explicitly
jenkinsci · Mar 10, 2012 · 8a4b5f6 · 8a4b5f6
1 parent 1364c0e
commit 8a4b5f6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/hudson/scm/CVSSCM.java b/src/main/java/hudson/scm/CVSSCM.java
@@ -56,6 +56,7 @@
 import java.util.Calendar;
 import java.util.Date;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -356,9 +357,10 @@ protected PollingResult compareRemoteRevisionWith(final AbstractProject<?, ?> pr
 
             // filter out all changes in the exclude regions
             for (final Pattern excludePattern : excludePatterns) {
-                for (final CvsFile change : filteredChanges) {
+                for (Iterator<CvsFile> itr = filteredChanges.iterator(); itr.hasNext(); ) {
+                    CvsFile change = itr.next();
                     if (excludePattern.matcher(change.getName()).matches()) {
-                        filteredChanges.remove(change);
+                        itr.remove();
                     }
                 }
             }