You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Or the person developing the patch should check that they aren't issuing a pull request like this. I've generally gone back and asked the person to fix the spacing difference so the diff is useful.
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the diff is so bad - Intellij IDEA highlighted the correct lines prior to my commit so I wonder if it's done something with line endings (it's not spaces vs tabs as it's even highlighted the import statements as modified and they're not indented). The change here is the addition of the readResolve() method for automatic modification during de-serialisation, and the reinstatement of the modules field (although marked as transient and deprecated) so we can read the legacy config structure.
I'll see if I can roll-back this commit and re-apply if once I'm back at my normal computer tonight.
The reason will be displayed to describe this comment to others. Learn more.
With the added NPE check described above I successfully converted a 2.3-style module config into a 2.4-style module config!
Thanks Michael for adding the readResolve() method. This will save a lot of time and pain.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this diff is completely useless. :(
I'll test it tomorrow.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably has different space vs. tab settings.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github definitely needs an option to ignore whitespaces.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or the person developing the patch should check that they aren't issuing a pull request like this. I've generally gone back and asked the person to fix the spacing difference so the diff is useful.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the diff is so bad - Intellij IDEA highlighted the correct lines prior to my commit so I wonder if it's done something with line endings (it's not spaces vs tabs as it's even highlighted the import statements as modified and they're not indented). The change here is the addition of the
readResolve()method for automatic modification during de-serialisation, and the reinstatement of themodulesfield (although marked as transient and deprecated) so we can read the legacy config structure.I'll see if I can roll-back this commit and re-apply if once I'm back at my normal computer tonight.
1db398aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the added NPE check described above I successfully converted a 2.3-style module config into a 2.4-style module config!
Thanks Michael for adding the readResolve() method. This will save a lot of time and pain.