[FIXED JENKINS-30941] Do not remove execute and write bit from direct…

…ories that need to be cleaned up
jenkinsci · Oct 15, 2015 · 3cd54c0 · 3cd54c0
1 parent 177dbd1
commit 3cd54c0
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java b/src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java
@@ -58,7 +58,14 @@ public class FileBinding extends Binding<FileCredentials> {
         secrets.chmod(/*0700*/448);
         FilePath secret = dir.child(credentials.getFileName());
         copy(secret, credentials);
-        secret.chmod(0400);
+        if (secret.isDirectory()) { /* ZipFileBinding */
+            // needs to be writable so we can delete its contents
+            // needs to be executable so we can list the contents
+            secret.chmod(0700);
+        }
+        else {
+            secret.chmod(0400);
+        }
         return new SingleEnvironment(secret.getRemote(), new UnbinderImpl(dirName));
     }