[JENKINS-22965] Cppcheck plugin shall display the inconclusive messages

- Inconclusive messages are displayed with gray text color.
jenkinsci · May 18, 2014 · 0814460 · 0814460
1 parent f1cf428
commit 0814460
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly b/src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
@@ -11,6 +11,7 @@
     #cppcheckDetails .new { background-color: #FFC8C8; }
     #cppcheckDetails .solved { background-color: #C8FFC8; }
     #cppcheckDetails .unchanged { }
+    #cppcheckDetails .inconclusive { color: #555555; }
     </style>
 
     <p><a href="source.all?before=5&amp;after=5">
@@ -32,8 +33,13 @@
         <tbody>
             <j:forEach var="elt" items="${cachedContainer}">
                 <j:set var="cppcheckFile" value="${elt.cppcheckFile}"/>
+
+                <j:set var="inconclusiveCss" value=""/>
+                <j:if test="${cppcheckFile.inconclusive}">
+                    <j:set var="inconclusiveCss" value="inconclusive"/>
+                </j:if>
 
-                <tr class="${elt.diffState.css}">
+                <tr class="${elt.diffState.css} ${inconclusiveCss}">
                     <td class="pane">${elt.diffState.text}</td>
                     <td class="pane">
                         <j:if test="${elt.isSourceIgnored()}">

diff --git a/src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly b/src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
@@ -10,6 +10,7 @@
             .newCppcheck { background-color: #FFC8C8; }
             .solvedCppcheck { background-color: #C8FFC8; }
             .unchangedCppcheck { }
+            .inconclusiveCppcheck { color: #555555; }
 
             .cppcheck h2 { margin-top: 0; }
             .cppcheck code { display: block; margin: 1em 0em 1em 0em; }
@@ -22,7 +23,12 @@
             <h1>${%Cppcheck Results}</h1>
 
             <j:forEach var="file" items="${it.files}">
-                <div class="cppcheck ${file.diffState.css}Cppcheck">
+                <j:set var="inconclusiveCss" value=""/>
+                <j:if test="${file.cppcheckFile.inconclusive}">
+                    <j:set var="inconclusiveCss" value="inconclusiveCppcheck"/>
+                </j:if>
+
+                <div class="cppcheck ${file.diffState.css}Cppcheck ${inconclusiveCss}">
                     <h2>${file.cppcheckFile.messageHtml}</h2>
 
                     <j:if test="${file.cppcheckFile.fileName != null}">