[FIXED JENKINS-8968] When both "block build when upstream/downstream …

…is building" are checked,the upstream block check wasn't taking effect.
jenkinsci · Mar 15, 2011 · 3f9e65d · 3f9e65d
1 parent b497728
commit 3f9e65d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changelog.html b/changelog.html
@@ -60,6 +60,9 @@
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
+  <li class=bug>
+    When both "block build when upstream/downstream is building" are checked, the upstream block check wasn't taking effect.
+    (<a href="http://issues.jenkins-ci.org/browse/JENKINS-8968">issue 8968</a>)
   <li class=rfe>
     Added the <tt>--mimeTypes</tt> command line option to define additional MIME type mappings.
   <li class=rfe>

diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java
@@ -1057,7 +1057,8 @@ public CauseOfBlockage getCauseOfBlockage() {
             AbstractProject<?,?> bup = getBuildingDownstream();
             if (bup!=null)
                 return new BecauseOfDownstreamBuildInProgress(bup);
-        } else if (blockBuildWhenUpstreamBuilding()) {
+        }
+        if (blockBuildWhenUpstreamBuilding()) {
             AbstractProject<?,?> bup = getBuildingUpstream();
             if (bup!=null)
                 return new BecauseOfUpstreamBuildInProgress(bup);