[JENKINS-17680] Make minimized diffs.

jenkinsci · Aug 3, 2013 · bc9cc18 · bc9cc18
1 parent 7214a14
commit bc9cc18
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/src/main/java/hudson/plugins/copyartifact/CopyArtifact.java b/src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
@@ -162,21 +162,22 @@ public boolean isOptional() {
 
     /* package scope */
     boolean upgradeIfNecessary(AbstractProject<?,?> job) throws IOException {
-        if (!isUpgradeNeeded()) {
-            return false;
-        }
-        int i = projectName.lastIndexOf('/');
-        if (i != -1 && projectName.indexOf('=', i) != -1 && /* not matrix */Jenkins.getInstance().getItem(projectName, job.getParent(), Job.class) == null) {
-            project = projectName.substring(0, i);
-            parameters = projectName.substring(i + 1);
+        if (isUpgradeNeeded()) {
+            int i = projectName.lastIndexOf('/');
+            if (i != -1 && projectName.indexOf('=', i) != -1 && /* not matrix */Jenkins.getInstance().getItem(projectName, job.getParent(), Job.class) == null) {
+                project = projectName.substring(0, i);
+                parameters = projectName.substring(i + 1);
+            } else {
+                project = projectName;
+                parameters = null;
+            }
+            Logger.getLogger(CopyArtifact.class.getName()).log(Level.INFO, "Split {0} into {1} with parameters {2}", new Object[] {projectName, project, parameters});
+            projectName = null;
+            job.save();
+            return true;
         } else {
-            project = projectName;
-            parameters = null;
+            return false;
         }
-        Logger.getLogger(CopyArtifact.class.getName()).log(Level.INFO, "Split {0} into {1} with parameters {2}", new Object[] {projectName, project, parameters});
-        projectName = null;
-        job.save();
-        return true;
     }
 
     private boolean isUpgradeNeeded() {