[JENKINS-30357] Added tests to reproduce JENKINS-30357, NPE when Para…

…meterizedBuildSelector in workflow, or using an undefined variable.
jenkinsci · Sep 21, 2015 · bab56aa · bab56aa
1 parent f494646
commit bab56aa
Showing 1 changed file with 120 additions and 0 deletions.
diff --git a/src/test/java/hudson/plugins/copyartifact/ParameterizedBuildSelectorTest.java b/src/test/java/hudson/plugins/copyartifact/ParameterizedBuildSelectorTest.java
@@ -0,0 +1,120 @@
+/*
+ * The MIT License
+ * 
+ * Copyright (c) 2015 IKEDA Yasuyuki
+ * 
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ * 
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ * 
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package hudson.plugins.copyartifact;
+
+import static org.junit.Assert.*;
+import jenkins.util.VirtualFile;
+import hudson.model.FreeStyleBuild;
+import hudson.model.FreeStyleProject;
+import hudson.model.ParametersAction;
+import hudson.model.StringParameterValue;
+import hudson.plugins.copyartifact.testutils.CopyArtifactUtil;
+import hudson.plugins.copyartifact.testutils.FileWriteBuilder;
+import hudson.tasks.ArtifactArchiver;
+import hudson.util.IOUtils;
+
+import org.jenkinsci.plugins.workflow.cps.CpsFlowDefinition;
+import org.jenkinsci.plugins.workflow.job.WorkflowJob;
+import org.jenkinsci.plugins.workflow.job.WorkflowRun;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.jvnet.hudson.test.Issue;
+import org.jvnet.hudson.test.JenkinsRule;
+
+/**
+ * Tests for {@link ParameterizedBuildSelector}
+ * 
+ * @see CopyArtifactTest#testParameterizedBuildSelector()
+ */
+public class ParameterizedBuildSelectorTest {
+    @ClassRule
+    public static JenkinsRule j = new JenkinsRule();
+
+    /**
+     * Should not cause a fatal error even for an undefined variable.
+     * 
+     * @throws Exception
+     */
+    @Issue("JENKINS-30357")
+    @Test
+    public void testUndefinedParameter() throws Exception {
+        FreeStyleProject copiee = j.createFreeStyleProject();
+        FreeStyleProject copier = j.createFreeStyleProject();
+
+        ParameterizedBuildSelector pbs = new ParameterizedBuildSelector("NosuchVariable");
+        copier.getBuildersList().add(CopyArtifactUtil.createCopyArtifact(
+                copiee.getFullName(),
+                null,   // parameters
+                pbs,
+                "**/*", // filter
+                "",     // excludes
+                false,  // flatten
+                true,   // optional
+                false   // finterprintArtifacts
+        ));
+        FreeStyleBuild b = copier.scheduleBuild2(0).get();
+        j.assertBuildStatusSuccess(b);
+    }
+
+    /**
+     * Also applicable for workflow jobs.
+     * 
+     * @throws Exception
+     */
+    @Issue("JENKINS-30357")
+    @Test
+    public void testWorkflow() throws Exception {
+        // Prepare an artifact to be copied.
+        FreeStyleProject copiee = j.createFreeStyleProject("copiee");
+        copiee.getBuildersList().add(new FileWriteBuilder("artifact.txt", "foobar"));
+        copiee.getPublishersList().add(new ArtifactArchiver("artifact.txt"));
+        j.assertBuildStatusSuccess(copiee.scheduleBuild2(0));
+
+        WorkflowJob copier = j.jenkins.createProject(WorkflowJob.class, "copier");
+        copier.setDefinition(new CpsFlowDefinition(
+                "node {"
+                    + "step([$class: 'CopyArtifact',"
+                        + "projectName: 'copiee',"
+                        + "filter: '**/*',"
+                        + "selector: [$class: 'ParameterizedBuildSelector', parameterName: 'SELECTOR'],"
+                    + "]);"
+                    + "step([$class: 'ArtifactArchiver', artifacts: '**/*']);"
+                + "}",
+                true
+        ));
+
+        WorkflowRun b = j.assertBuildStatusSuccess(copier.scheduleBuild2(
+                0,
+                null,
+                new ParametersAction(new StringParameterValue(
+                        "SELECTOR",
+                        "<StatusBuildSelector><stable>true</stable></StatusBuildSelector>"
+                ))
+        ));
+
+        VirtualFile vf = b.getArtifactManager().root().child("artifact.txt");
+        assertEquals("foobar", IOUtils.toString(vf.open()));
+    }
+}