Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
JENKINS-16869: I can't reproduce the problem reported, but I do see that
you can see the timestamper configuration slicer even when the
timestamper plugin is not installed, which gives you this error. I've
made a change so that the button is not enabled if the plugin is not
available.
  • Loading branch information
ninian committed Oct 3, 2014
1 parent a150eb8 commit 712db1a
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/main/java/configurationslicing/maven/MavenGoals.java
Expand Up @@ -17,6 +17,12 @@ public MavenGoals() {
super(new MavenGoalsSlicerSpec());
}

@Override
public void loadPluginDependencyClass() {
// this is just to demonstrate that the Maven plugin is loaded
MavenModuleSet.class.getClass();
}

public static class MavenGoalsSlicerSpec extends UnorderedStringSlicerSpec<MavenModuleSet> {
private static final String DEFAULT = "(Default)";

Expand Down
Expand Up @@ -7,7 +7,6 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Set;

import configurationslicing.UnorderedStringSlicer;

Expand All @@ -18,6 +17,12 @@ public MavenOptsSlicer() {
super(new MavenOptsSlicerSpec());
}

@Override
public void loadPluginDependencyClass() {
// this is just to demonstrate that the Maven plugin is loaded
MavenModuleSet.class.getClass();
}

public static class MavenOptsSlicerSpec extends UnorderedStringSlicerSpec<MavenModuleSet> {

public String getDefaultValueString() {
Expand Down
Expand Up @@ -19,6 +19,12 @@ public class PrioritySorterSlicer extends UnorderedStringSlicer<Job<?,?>>{
public PrioritySorterSlicer() {
super(new PrioritySorterSliceSpec());
}

@Override
public void loadPluginDependencyClass() {
// this is just to demonstrate that the PrioritySorter plugin is loaded
PrioritySorterJobProperty.class.getClass();
}

public static class PrioritySorterSliceSpec extends UnorderedStringSlicerSpec<Job<?,?>> {

Expand Down
Expand Up @@ -22,6 +22,12 @@ public TimestamperSlicer() {
super(new TimestamperSliceSpec());
}

@Override
public void loadPluginDependencyClass() {
// this is just to demonstrate that the Timestamper plugin is loaded
TimestamperBuildWrapper.class.getClass();
}

public static class TimestamperSliceSpec extends UnorderedStringSlicerSpec<AbstractProject<?,?>> {

private static final String DISABLED = Boolean.FALSE.toString();
Expand Down

0 comments on commit 712db1a

Please sign in to comment.