[JENKINS-20403] add test case

jenkinsci · Nov 4, 2013 · 50e528c · 50e528c
1 parent f0334ad
commit 50e528c
Showing 1 changed file with 57 additions and 14 deletions.
diff --git a/src/test/java/org/jenkinsci/plugins/configfiles/maven/job/MvnSettingsProviderTest.java b/src/test/java/org/jenkinsci/plugins/configfiles/maven/job/MvnSettingsProviderTest.java
@@ -1,5 +1,7 @@
 package org.jenkinsci.plugins.configfiles.maven.job;
 
+import java.util.Collections;
+
 import hudson.maven.MavenModuleSet;
 import hudson.model.Item;
 import hudson.model.FreeStyleProject;
@@ -8,12 +10,22 @@
 import org.jenkinsci.lib.configprovider.ConfigProvider;
 import org.jenkinsci.lib.configprovider.model.Config;
 import org.jenkinsci.plugins.configfiles.ConfigFilesManagement;
+import org.jenkinsci.plugins.configfiles.buildwrapper.ConfigFileBuildWrapper;
+import org.jenkinsci.plugins.configfiles.buildwrapper.ManagedFile;
 import org.jenkinsci.plugins.configfiles.maven.GlobalMavenSettingsConfig.GlobalMavenSettingsConfigProvider;
 import org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig.MavenSettingsConfigProvider;
+import org.junit.Assert;
 import org.junit.Rule;
 import org.junit.Test;
 import org.jvnet.hudson.test.Bug;
 import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.JenkinsRule.WebClient;
+
+import com.gargoylesoftware.htmlunit.html.DomNodeList;
+import com.gargoylesoftware.htmlunit.html.HtmlElement;
+import com.gargoylesoftware.htmlunit.html.HtmlOption;
+import com.gargoylesoftware.htmlunit.html.HtmlPage;
+import com.gargoylesoftware.htmlunit.html.HtmlTextInput;
 
 import javax.inject.Inject;
 
@@ -24,18 +36,19 @@
  */
 public class MvnSettingsProviderTest {
     @Rule
-    public JenkinsRule jenkins = new JenkinsRule();
+    public JenkinsRule                jenkins = new JenkinsRule();
 
     @Inject
-    ConfigFilesManagement config;
+    ConfigFilesManagement             config;
 
     @Inject
-    MavenSettingsConfigProvider mavenSettingProvider;
+    MavenSettingsConfigProvider       mavenSettingProvider;
 
     @Inject
     GlobalMavenSettingsConfigProvider globalMavenSettingsConfigProvider;
 
-    @Test @Bug(15976)
+    @Test
+    @Bug(15976)
     public void testConfigRoundtrip() throws Exception {
         jenkins.jenkins.getInjector().injectMembers(this);
 
@@ -45,15 +58,15 @@ public void testConfigRoundtrip() throws Exception {
         FreeStyleProject p = jenkins.createFreeStyleProject();
         MvnSettingsProvider s1 = new MvnSettingsProvider(c1.id);
         MvnGlobalSettingsProvider s2 = new MvnGlobalSettingsProvider(c2.id);
-        Maven m = new Maven("install", null,null,null,null,false, s1, s2);
+        Maven m = new Maven("install", null, null, null, null, false, s1, s2);
         p.getBuildersList().add(m);
-        jenkins.configRoundtrip((Item)p);
+        jenkins.configRoundtrip((Item) p);
         m = p.getBuildersList().get(Maven.class);
 
-        jenkins.assertEqualDataBoundBeans(m.getSettings(),s1);
-        jenkins.assertEqualDataBoundBeans(m.getGlobalSettings(),s2);
+        jenkins.assertEqualDataBoundBeans(m.getSettings(), s1);
+        jenkins.assertEqualDataBoundBeans(m.getGlobalSettings(), s2);
         assertNotSame(m.getSettings(), s1);
-        assertNotSame(m.getGlobalSettings(),s2);
+        assertNotSame(m.getGlobalSettings(), s2);
     }
 
     private Config createSetting(ConfigProvider provider) {
@@ -62,7 +75,8 @@ private Config createSetting(ConfigProvider provider) {
         return c1;
     }
 
-    @Test @Bug(15976)
+    @Test
+    @Bug(15976)
     public void testConfigRoundtripMavenJob() throws Exception {
         jenkins.jenkins.getInjector().injectMembers(this);
 
@@ -74,11 +88,40 @@ public void testConfigRoundtripMavenJob() throws Exception {
         MvnGlobalSettingsProvider s2 = new MvnGlobalSettingsProvider(c2.id);
         p.setSettings(s1);
         p.setGlobalSettings(s2);
-        jenkins.configRoundtrip((Item)p);
+        jenkins.configRoundtrip((Item) p);
 
-        jenkins.assertEqualDataBoundBeans(p.getSettings(),s1);
-        jenkins.assertEqualDataBoundBeans(p.getGlobalSettings(),s2);
+        jenkins.assertEqualDataBoundBeans(p.getSettings(), s1);
+        jenkins.assertEqualDataBoundBeans(p.getGlobalSettings(), s2);
         assertNotSame(p.getSettings(), s1);
-        assertNotSame(p.getGlobalSettings(),s2);
+        assertNotSame(p.getGlobalSettings(), s2);
+    }
+
+    @Test
+    @Bug(20403)
+    public void configMustBeVisbleFromConfigPage() throws Exception {
+        jenkins.jenkins.getInjector().injectMembers(this);
+
+        final WebClient client = jenkins.createWebClient();
+        {
+            Config c1 = createSetting(mavenSettingProvider);
+            // http://localhost:8080/configfiles/show?id=org.jenkinsci.plugins.configfiles.maven.MavenSettingsConfig1383601194902
+            final HtmlPage page = client.goTo("configfiles/show?id=" + c1.id);
+
+            final HtmlTextInput name = page.getElementByName("config.name");
+            final HtmlTextInput comment = page.getElementByName("config.comment");
+            Assert.assertEquals("name NOK", c1.name, name.getValueAttribute());
+            Assert.assertEquals("comment NOK", c1.comment, comment.getValueAttribute());
+        }
+        {
+            // GlobalMavenSettingsConfig
+            Config c2 = createSetting(globalMavenSettingsConfigProvider);
+            // http://localhost:8080/configfiles/show?id=org.jenkinsci.plugins.configfiles.maven.GlobalMavenSettingsConfig23435346436324
+            final HtmlPage page = client.goTo("configfiles/show?id=" + c2.id);
+
+            final HtmlTextInput name = page.getElementByName("config.name");
+            final HtmlTextInput comment = page.getElementByName("config.comment");
+            Assert.assertEquals("name NOK", c2.name, name.getValueAttribute());
+            Assert.assertEquals("comment NOK", c2.comment, comment.getValueAttribute());
+        }
     }
 }