Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[FIXED JENKINS-15445] rely on 1.536 so JENKINS-18629 doesn’t prevent …
…BuildStep without a @DataBoundConstructor to be used.
- Loading branch information
Showing
2 changed files
with
3 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132178a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndeloof I think we had this before already once and we had to revert it because jenkins could not handle it. Is there anything fixed in core which now makes you think this would work?
If you refer to the fix for https://issues.jenkins-ci.org/browse/JENKINS-20262, then this will not work - because this change was reverted in core 1.537 again.
132178a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imod yes, I re-applied this based on fix made on stappler (so requirement for 1.536), didn't know this has been reverted in 1.537. What a pity. reverting this commit.
132178a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndeloof yeah, its quite a shame I was so hopping this is going to work now :(