[JENKINS-11898] Create view if view doesn't exist doesn't work for

dynamic views
jenkinsci · Nov 13, 2012 · 35996f3 · 35996f3
1 parent 2e78a8c
commit 35996f3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/main/java/hudson/plugins/clearcase/ClearToolExec.java b/src/main/java/hudson/plugins/clearcase/ClearToolExec.java
@@ -649,17 +649,11 @@ public void mkview(MkViewParameters parameters) throws IOException, InterruptedE
         }
 
         // add the default storage directory only if gpath/hpath are not set (only for windows)
-        switch (parameters.getType()) {
-        case Snapshot:
-            if (!isMetadataLocationDefinedInAdditionalParameters) {
-                cmd.add(parameters.getViewStorage().getCommandArguments());
-            }
+        if (!isMetadataLocationDefinedInAdditionalParameters) {
+            cmd.add(parameters.getViewStorage().getCommandArguments());
+        }
+        if (ViewType.Snapshot.equals(parameters.getType())) {
             cmd.add(parameters.getViewPath());
-            break;
-        case Dynamic:
-
-            break;
-        default:
         }
         launcher.run(cmd.toCommandArray(), null, null, null, true);
     }

diff --git a/src/main/java/hudson/plugins/clearcase/action/UcmDynamicCheckoutAction.java b/src/main/java/hudson/plugins/clearcase/action/UcmDynamicCheckoutAction.java
@@ -178,6 +178,7 @@ private void prepareBuildStreamAndViews(String viewTag, String stream) throws IO
 
     private void prepareView(String viewTag, String stream) throws IOException, InterruptedException {
         MkViewParameters params = new MkViewParameters();
+        params.setType(ViewType.Dynamic);
         params.setViewTag(viewTag);
         params.setStreamSelector(stream);
         params.setViewStorage(getViewStorage());