[FIXED JENKINS-39538] "Claim it" link for tests didn't work when Buil…

…d-Failure-Analyzer wasn't installed. Leading to Javascript errors such as "Uncaught ReferenceError: ShowPopup is not defined".
jenkinsci · Nov 7, 2016 · e83bf64 · e83bf64
1 parent 99963f0
commit e83bf64
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java b/src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
@@ -217,16 +217,14 @@ public String getReason() {
     }
 
     public String fillReason() throws Exception {
+        JSONObject json = new JSONObject();
         if(ClaimBuildFailureAnalyzer.isBFAEnabled()) {
             HashMap<String, String> map = ClaimBuildFailureAnalyzer.getFillReasonMap();
-            JSONObject json = new JSONObject();
             for (String key : map.keySet()) {
                 json.put(key, map.get(key));
             }
-            String causeMap = json.toString();
-            return causeMap;
         }
-        return null;
+        return json.toString();
     }
 
     public void setReason(String reason) {