Skip to content

Commit

Permalink
Merge pull request #10 from jenkinsci/Le0Michine-fix-for-bug-34181
Browse files Browse the repository at this point in the history 
Fix for bug JENKINS-34181 NPE after plugin update
  • Loading branch information
@Le0Michine
Le0Michine committed Apr 14, 2016
2 parents 32b82bd + d91a0d6 commit 2234e39
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/plugins/buildnamesetter/BuildNameSetter.java
View file
Expand Up @@ -26,8 +26,8 @@
public class BuildNameSetter extends BuildWrapper implements MatrixAggregatable {

public final String template;
public final Boolean runAtStart;
public final Boolean runAtEnd;
public boolean runAtStart = true;
public boolean runAtEnd = true;

@DataBoundConstructor
public BuildNameSetter(String template, Boolean runAtStart, Boolean runAtEnd) {
Expand Down

4 comments on commit 2234e39

@Sauraus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default behaviour of the plugin, and breaks any job already defined!

@Le0Michine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sauraus not exactly. Until version 1.6.0 plugin was run at the beginning and at the end of the build by default so it is equivalent to case when both options are true

@Sauraus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, its the change in 1.6.0 that caused the NPE... got ya.

@Le0Michine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sauraus anyway thanks for the comment, I made an additional check :)

Please sign in to comment.