[JENKINS-32651] Fix calculation of report begin date

Currently, computation is done using Calendar.roll() which is wrong. roll() only changes a specific unit and doesn't update larger fields. For example, rolling back 2 week on the first week of a month sets the calendar week to the last week of the month, which is in the future. Obviously, when the begin date is in the future, there's nothing in the report. Using Calendar.add() with a negative value substracts the right amount of time from the current time.
jenkinsci · Jan 27, 2016 · 3b10254 · 3b10254
1 parent ba4ef5c
commit 3b10254
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/jenkins/plugins/build_metrics/BuildMetricsPluginSearchFactory.java b/src/main/java/jenkins/plugins/build_metrics/BuildMetricsPluginSearchFactory.java
@@ -82,7 +82,7 @@ public Long getStartDate(int range, String rangeUnits){
 	      iUnits = Calendar.YEAR;
 		}
 		Calendar tmpCal = Calendar.getInstance();
-		tmpCal.roll(iUnits, iRange);
+		tmpCal.add(iUnits, iRange);
 		return new Long(tmpCal.getTimeInMillis());
 	}