[JENKINS-51402] Presigned url has the wrong region

when running from a different one
jenkinsci · May 22, 2018 · 83fa829 · 83fa829
1 parent ea314b9
commit 83fa829
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManager.java b/src/main/java/io/jenkins/plugins/artifact_manager_s3/JCloudsArtifactManager.java
@@ -354,6 +354,8 @@ public Void invoke(File f, VirtualChannel channel) throws IOException, Interrupt
      * Upload a file to a URL
      */
     private static void uploadFile(Path f, URL url) throws IOException {
+        // AWS will redirect to the bucket region if different
+        HttpURLConnection.setFollowRedirects(true);
         HttpURLConnection connection = (HttpURLConnection) url.openConnection();
         connection.setDoOutput(true);
         connection.setRequestMethod("PUT");
@@ -362,7 +364,7 @@ private static void uploadFile(Path f, URL url) throws IOException {
             Files.copy(f, out);
         }
         int responseCode = connection.getResponseCode();
-        if (responseCode < 200 || responseCode >= 300) {
+        if (responseCode < 200 || responseCode >= 400) {
             throw new IOException(String.format("Failed to upload %s to %s, response: %d %s", f.toAbsolutePath(), url,
                     responseCode, connection.getResponseMessage()));
         }