Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Commit

Permalink
[FIXED JENKINS-16075] Remove redundant resource path from icon URL.
Browse files Browse the repository at this point in the history 
Apparently the fix for JENKINS-16530 now includes this automatically
for all plugin images, regardless of whether the plugin was already
doing the right thing and allowing caching.
  • Loading branch information
@orrc
orrc committed Apr 10, 2013
1 parent 16db36f commit 7d90c1d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/main/java/org/jenkinsci/plugins/android_lint/LintDescriptor.java
View file
@@ -1,7 +1,6 @@
package org.jenkinsci.plugins.android_lint;

import hudson.Extension;
import hudson.Functions;
import hudson.plugins.analysis.core.PluginDescriptor;

/**
Expand All @@ -17,7 +16,7 @@ public final class LintDescriptor extends PluginDescriptor {
public static final String PLUGIN_NAME = "androidLint";

/** Used to specify location of resources. */
public static final String PLUGIN_ROOT = Functions.getResourcePath() + "/plugin/android-lint/";
public static final String PLUGIN_ROOT = "/plugin/android-lint/";

/** Icon to use for the result and project action. */
private static final String ACTION_ICON = PLUGIN_ROOT + "icons/android-24x24.png";
Expand Down

2 comments on commit 7d90c1d

@jglick
Copy link
Member

@jglick jglick commented on 7d90c1d Apr 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least for icons used from <l:task> in recent Jenkins releases.

@orrc
Copy link
Member Author

@orrc orrc commented on 7d90c1d Apr 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, though I hope that pretty much all plugin images are now cached automatically by core, as I've had to undo the caching I eagerly added in my plugins now a few times now! :)

Please sign in to comment.