[FIXED JENKINS-38532] Add unit tests

jenkinsci · Nov 26, 2016 · 528443a · 528443a
1 parent 6a4e6aa
commit 528443a
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 0 deletions.
diff --git a/src/test/java/org/biouno/unochoice/issue38532/TestParameterValuesWithEquals.java b/src/test/java/org/biouno/unochoice/issue38532/TestParameterValuesWithEquals.java
@@ -0,0 +1,92 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2014-2016 Ioannis Moutsatsos, Bruno P. Kinoshita
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package org.biouno.unochoice.issue38532;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+import java.util.Map;
+
+import org.biouno.unochoice.CascadeChoiceParameter;
+import org.biouno.unochoice.ChoiceParameter;
+import org.biouno.unochoice.DynamicReferenceParameter;
+import org.biouno.unochoice.model.GroovyScript;
+import org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript;
+import org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApproval;
+import org.jenkinsci.plugins.scriptsecurity.scripts.languages.GroovyLanguage;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.jvnet.hudson.test.Issue;
+import org.jvnet.hudson.test.JenkinsRule;
+
+/**
+ * Test that scripts can access global node properties.
+ *
+ * @since 1.5.x
+ */
+@Issue("JENKINS-38532")
+public class TestParameterValuesWithEquals {
+
+    @Rule
+    public JenkinsRule j = new JenkinsRule();
+
+    // LIST script
+    private final String SCRIPT_LIST = "return ['A=1', 'B=2', 'C=3']";
+    private final String FALLBACK_SCRIPT_LIST = "return ['EMPTY!']";
+
+    // LIST_SELECTION script
+    private final String SCRIPT_LIST_SELECTION = "value = LIST.toString()\nreturn \"${value}\"";
+    private final String FALLBACK_SCRIPT_LIST_SELECTION = "return ['EMPTY!']";
+
+    @Before
+    public void setUp() throws Exception {
+        ScriptApproval.get().preapprove(SCRIPT_LIST, GroovyLanguage.get());
+        ScriptApproval.get().preapprove(FALLBACK_SCRIPT_LIST, GroovyLanguage.get());
+        ScriptApproval.get().preapprove(SCRIPT_LIST_SELECTION, GroovyLanguage.get());
+        ScriptApproval.get().preapprove(FALLBACK_SCRIPT_LIST_SELECTION, GroovyLanguage.get());
+    }
+
+    @Test
+    public void testEvaluationWorksEvenThoughWeUsedEqualsInParameterValues() throws IOException {
+        GroovyScript listScript = new GroovyScript(new SecureGroovyScript(SCRIPT_LIST, Boolean.FALSE, null),
+                new SecureGroovyScript(FALLBACK_SCRIPT_LIST, Boolean.FALSE, null));
+        GroovyScript listSelectionScript = new GroovyScript(
+                new SecureGroovyScript(SCRIPT_LIST_SELECTION, Boolean.FALSE, null),
+                new SecureGroovyScript(FALLBACK_SCRIPT_LIST_SELECTION, Boolean.FALSE, null));
+        ChoiceParameter listParam = new ChoiceParameter("LIST", "description...", "random-name1", listScript,
+                CascadeChoiceParameter.PARAMETER_TYPE_SINGLE_SELECT, true);
+        DynamicReferenceParameter listSelectionParam = new DynamicReferenceParameter("LIST_SELECTION", "description...",
+                "random-name2", listSelectionScript, CascadeChoiceParameter.ELEMENT_TYPE_FORMATTED_HIDDEN_HTML, "LIST",
+                true);
+        String listValue = listParam.getDefaultParameterValue().getValue().toString(); // should be a String
+        listSelectionParam.doUpdate(String.format(String.format("%s=%s", listParam.getName(), listValue)));
+        String listSelectionValue = listSelectionParam.getChoicesAsString(); // as this is a formatted hidden HTML...
+
+        // by default, the plug-in returns the first element in the list...
+        assertEquals("Value returned from selection list doesn't match first element in list parameter", "A=1",
+                listSelectionValue);
+    }
+
+}
diff --git a/src/test/java/org/biouno/unochoice/issue38532/package-info.java b/src/test/java/org/biouno/unochoice/issue38532/package-info.java
@@ -0,0 +1,29 @@
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2014-2016 Ioannis Moutsatsos, Bruno P. Kinoshita
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+/**
+ * Tests for parameters with the equals separator. See JENKINS-38532.
+ * @since 1.5.x
+ */
+package org.biouno.unochoice.issue38532;