Skip to content

Commit

Permalink
Code cleanup, Jenkins-4369 FIX, Log spamming, Javadoc (#25)
Browse files Browse the repository at this point in the history 
* ignore intellij

* fixed failing test

Test needed jelly escape by default set to true

* Override not allowed on interface method

Override is not allowed when implementing interface method

* JENKINS-4369 Fix - Workspace relocation check false positivities

#11

* Spamming log

* Uncessary cast

* Unused import

* Redundant modifier

* Unnecessary boxing

* for loop instead of while.

* Redundant modifier

* First stab at updating to 2.7 LTS

Still need a few more deprecation warning to go away.

* Fix unchecked

* Try with Resource

* Collapsed catch

* Forgot to remove redundant cast

* Diamond types

* Code cleanup and unused imports

* Proper comment

* First fix to JavaDoc

* Javadoc only

* Findbugs: Garbage collection call it bad

* FindBug: Method call passes null for non-null parameter

* FindBugs: Reliance on default encoding

* more idea ignore

* All FindBugs, fixed.

* Update .gitignore

* Target java 1.8

* FindBugs null pointer

Possible null pointer dereference due to return value of called method
Also optimise import

* Some more and some less null pointer

Please pass already 😄

* FindBug dance 🎉

* deprecation warnings cleared, some more code cleanup.

Tested on Jenkins 2.7

* Bumping to 2.13 jenkins plugin

Last touch 🎉

* ��Last one, installation path on macOS 🍎

MacOS default installation with the anywhere installer is now on
Applications/AccuRev.

* Unused dependency?

* unused import

* bump plugin versions

* update maintainer

* prepare for 0.7.0 release
  • Loading branch information
@jetersen
jetersen committed Aug 28, 2016
1 parent ac85040 commit 53d6292
Show file tree
Hide file tree
Showing 52 changed files with 611 additions and 625 deletions.
2 changes: 2 additions & 0 deletions .gitignore
View file
Expand Up @@ -5,3 +5,5 @@ work
.classpath
.project
.settings
.idea
*.iml
120 changes: 72 additions & 48 deletions pom.xml
View file
@@ -1,79 +1,103 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>1.525</version>
<version>2.13</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>accurev</artifactId>
<packaging>hpi</packaging>
<version>0.6.36-SNAPSHOT</version>
<version>0.7.0-SNAPSHOT</version>
<name>Jenkins Accurev plugin</name>
<url>http://wiki.jenkins-ci.org/display/JENKINS/AccuRev+Plugin</url>

<developers>
<developer>
<id>statler</id>
<name>Scott Tatum</name>
</developer>
<developer>
<id>helterscelter</id>
<name>Clint Martin</name>
</developer>
<developer>
<id>casz</id>
<name>Joseph Petersen</name>
</developer>
</developers>

<dependencies>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
<version>1.5.1</version>
</dependency>
</dependencies>

<scm>
<connection>scm:git:git://github.com/jenkinsci/accurev-plugin.git</connection>
<developerConnection>scm:git:git@github.com:jenkinsci/accurev-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/accurev-plugin</url>
<connection>scm:git:git://github.com/jenkinsci/accurev-plugin.git</connection>
<developerConnection>scm:git:git@github.com:jenkinsci/accurev-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/accurev-plugin</url>
</scm>

<distributionManagement>
<repository>
<id>maven.jenkins-ci.org</id>
<url>http://maven.jenkins-ci.org:8081/content/repositories/releases</url>
<uniqueVersion>false</uniqueVersion>
<id>maven.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/releases/</url>
</repository>
<snapshotRepository>
<id>maven.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/snapshots/</url>
</snapshotRepository>
</distributionManagement>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.0</version>
<dependencies>
<dependency>
<groupId>org.apache.maven.scm</groupId>
<artifactId>maven-scm-provider-gitexe</artifactId>
<version>1.3</version>
</dependency>
</dependencies>
<configuration>
<goals>deploy</goals>
</configuration>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.5.3</version>
<dependencies>
<dependency>
<groupId>org.apache.maven.scm</groupId>
<artifactId>maven-scm-provider-gitexe</artifactId>
<version>1.9.5</version>
</dependency>
</dependencies>
<configuration>
<goals>deploy</goals>
</configuration>

</plugin>
</plugins>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
<version>1.15</version>
<configuration>
<signature>
<groupId>org.codehaus.mojo.signature</groupId>
<artifactId>java18</artifactId>
<version>1.0</version>
</signature>
</configuration>
<executions>
<execution>
<id>ensure-java-1.8-class-library</id>
<phase>test</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.5.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
</plugins>
</build>

<licenses>
<license>
<name>The MIT license</name>
<url>http://www.opensource.org/licenses/mit-license.php</url>
<distribution>repo</distribution>
</license>
</licenses>
<licenses>
<license>
<name>The MIT license</name>
<url>http://www.opensource.org/licenses/mit-license.php</url>
<distribution>repo</distribution>
</license>
</licenses>

<repositories>
<repository>
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/hudson/plugins/accurev/AccurevChangeLogSet.java
View file
@@ -1,6 +1,6 @@
package hudson.plugins.accurev;

import hudson.model.AbstractBuild;
import hudson.model.Run;
import hudson.scm.ChangeLogSet;

import java.util.Collection;
Expand All @@ -21,13 +21,14 @@
public final class AccurevChangeLogSet extends ChangeLogSet<AccurevTransaction> {
private final List<AccurevTransaction> transactions;

AccurevChangeLogSet(AbstractBuild build, List<AccurevTransaction> transactions) {
super(build);
AccurevChangeLogSet(Run build, List<AccurevTransaction> transactions) {
// TODO: Implement RepositoryBrowser?
super(build, null);
if (transactions == null) {
throw new NullPointerException("Cannot have a null transaction list");
}
this.transactions = Collections.unmodifiableList(transactions);
for (AccurevTransaction transaction : transactions) {
for (AccurevTransaction transaction: transactions) {
transaction.setParent(this);
}
}
Expand Down

0 comments on commit 53d6292

Please sign in to comment.